Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Fix Phase2 ditau HLT path (with DeepTau Isolation) #43912

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 8, 2024

backport of #43855

PR description:

This PR implements the usage of Phase2 DeepTau training for ditau Phase 2 trigger, which was integrated with #42562. In the integrated version, Run2 training files were used. The problem with this implementation has been fixed and this PR proposes this fix and necessary changes.

Hopefully it will fix the issue mentioned here: #42862

The related JIRA ticket is CMSHLT-3010

PR validation:

The basic tests has been performed, suggested in the CMSSW PR instructions.
There was no failed tests.
See also #43855 (comment).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #43855

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoTauTag/RecoTau (reconstruction)

@mandrenguyen, @mmusich, @Martin-Grunewald, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@silviodonato, @azotz, @SohamBhattacharya, @Martin-Grunewald, @mbluj, @rovere, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4b495/37301/summary.html
COMMIT: 6d0a80f
CMSSW: CMSSW_14_0_X_2024-02-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43912/37301/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 53 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248601
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 8, 2024

+hlt

@mmusich
Copy link
Contributor Author

mmusich commented Feb 9, 2024

type tau

@cmsbuild cmsbuild added the tau label Feb 9, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Feb 12, 2024

ping @cms-sw/reconstruction-l2

@mandrenguyen
Copy link
Contributor

type bug-fix

@mandrenguyen
Copy link
Contributor

backport of #43855

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 40857a0 into cms-sw:CMSSW_14_0_X Feb 12, 2024
10 checks passed
@mmusich mmusich deleted the tauHLTPhase2_devel branch February 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants